svenvanheugten/night-light
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve names for generators

Browse source
This commit is contained in:
Sven van Heugten 2026-01-06 12:40:57 +01:00
parent d6820f5c02
commit 75e1170cf2
2 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
NightLight.Core.Tests/InteractionListGenerators.fs
View file

@ -22,7 +22,7 @@ let private genInteractionsListThatStartsWithTimeChanged =
[ genTimeChanged |> Gen.map List.singleton; Gen.listOf genInteraction ]
|> concatGens
let genInteractionListThatStartsWithTimeChangedAndEndsWith (endsWith: Interaction) =
let genInitialInteractionsAndEndWith (endsWith: Interaction) =
let genNonTrivialList =
genInteractionsListThatStartsWithTimeChanged
|> Gen.map (fun lst -> lst @ [ endsWith ])
@ -33,5 +33,5 @@ let genInteractionListThatStartsWithTimeChangedAndEndsWith (endsWith: Interactio
Gen.frequency [ 1, genTrivialList; 9, genNonTrivialList ]
| _ -> genNonTrivialList
let genInteractionListExcept disqualifier =
let genInteractionsExcept disqualifier =
genInteraction |> Gen.filter (not << disqualifier) |> Gen.listOf

22
NightLight.Core.Tests/NightLightTests.fs
View file

@ -40,8 +40,8 @@ type NightLightTests() =
[<Property>]
let ``All lights that are on should be white or yellow during the day`` () =
concatGens
[ Gen.bind genInteractionListThatStartsWithTimeChangedAndEndsWith genTimeChangedToDay
genInteractionListExcept isTimeChangedToNight ]
[ Gen.bind genInitialInteractionsAndEndWith genTimeChangedToDay
genInteractionsExcept isTimeChangedToNight ]
|> Arb.fromGen
|> Prop.forAll
<| fun interactions ->
@ -53,8 +53,8 @@ type NightLightTests() =
[<Property>]
let ``All lights that are on should be red during the night`` () =
concatGens
[ Gen.bind genInteractionListThatStartsWithTimeChangedAndEndsWith genTimeChangedToNight
genInteractionListExcept isTimeChangedToDay ]
[ Gen.bind genInitialInteractionsAndEndWith genTimeChangedToNight
genInteractionsExcept isTimeChangedToDay ]
|> Arb.fromGen
|> Prop.forAll
<| fun interactions ->
@ -68,8 +68,8 @@ type NightLightTests() =
()
=
concatGens
[ genInteractionListThatStartsWithTimeChangedAndEndsWith (HumanInteraction RemotePressedOnButton)
genInteractionListExcept ((=) (HumanInteraction RemotePressedOffButton)) ]
[ genInitialInteractionsAndEndWith (HumanInteraction RemotePressedOnButton)
genInteractionsExcept ((=) (HumanInteraction RemotePressedOffButton)) ]
|> Arb.fromGen
|> Prop.forAll
<| fun interactions ->
@ -86,8 +86,8 @@ type NightLightTests() =
()
=
concatGens
[ genInteractionListThatStartsWithTimeChangedAndEndsWith (HumanInteraction RemotePressedOffButton)
genInteractionListExcept (fun interaction ->
[ genInitialInteractionsAndEndWith (HumanInteraction RemotePressedOffButton)
genInteractionsExcept (fun interaction ->
interaction = HumanInteraction RemotePressedOnButton
|| interaction |> isTimeChangedToDay) ]
|> Arb.fromGen
@ -105,13 +105,13 @@ type NightLightTests() =
=
let genInitialInteractionsListThatEndsWithTransitionToDay =
concatGens
[ Gen.bind genInteractionListThatStartsWithTimeChangedAndEndsWith genTimeChangedToNight
genInteractionListExcept isTimeChangedToDay
[ Gen.bind genInitialInteractionsAndEndWith genTimeChangedToNight
genInteractionsExcept isTimeChangedToDay
Gen.map List.singleton genTimeChangedToDay ]
concatGens
[ genInitialInteractionsListThatEndsWithTransitionToDay
genInteractionListExcept ((=) (HumanInteraction RemotePressedOffButton)) ]
genInteractionsExcept ((=) (HumanInteraction RemotePressedOffButton)) ]
|> Arb.fromGen
|> Prop.forAll
<| fun interactions ->