From cbc948c005cc6e9ce55491e77129e1b5b996e85e Mon Sep 17 00:00:00 2001 From: Sven van Heugten Date: Fri, 16 Jan 2026 21:19:54 +0100 Subject: [PATCH] Re-use getPartOfDayAfterInteractions in an ensure... function --- NightLight.Core.Tests/InteractionListGenerators.fs | 10 +--------- NightLight.Core.Tests/NightLightTests.fs | 5 +++-- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/NightLight.Core.Tests/InteractionListGenerators.fs b/NightLight.Core.Tests/InteractionListGenerators.fs index 8202a63..c4412a6 100644 --- a/NightLight.Core.Tests/InteractionListGenerators.fs +++ b/NightLight.Core.Tests/InteractionListGenerators.fs @@ -70,15 +70,7 @@ let ensureLightHasPower (light: Light) (genInteractions: Gen) let ensurePartOfDayIs (desiredPartOfDay: PartOfDay) (genInteractions: Gen) = genInteractions |> Gen.bind (fun interactions -> - let maybeActualTime = - interactions - |> Seq.choose (fun interaction -> - match interaction with - | Interaction.TimeChanged time -> Some time - | _ -> None) - |> Seq.tryLast - - if maybeActualTime |> Option.map getPartOfDay = Some desiredPartOfDay then + if getPartOfDayAfterInteractions interactions = desiredPartOfDay then Gen.constant interactions else desiredPartOfDay diff --git a/NightLight.Core.Tests/NightLightTests.fs b/NightLight.Core.Tests/NightLightTests.fs index c55ec08..8ed5ab3 100644 --- a/NightLight.Core.Tests/NightLightTests.fs +++ b/NightLight.Core.Tests/NightLightTests.fs @@ -85,10 +85,11 @@ type NightLightTests() = (light: Light) = concatGens - [ genBiasedInteractions light |> ensurePartOfDayIs Night + [ genBiasedInteractions light + |> ensureStartsWithTimeChanged + |> ensurePartOfDayIs Night genTimeChangedToPartOfDay Day |> Gen.map List.singleton genBiasedInteractionsExcept light _.IsRemoteInteraction ] - |> ensureStartsWithTimeChanged |> ensureLightHasPower light |> Arb.fromGen |> Prop.forAll