svenvanheugten/night-light
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove Time on FakeHome

Browse source 
We'll have a lot more stuff that we need to compute from the actual
interactions, so let's just get the boilerplate ready.
This commit is contained in:
Sven van Heugten 2026-01-04 19:42:28 +01:00
parent c8e1f0c9fe
commit db4434cd20
2 changed files with 23 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

14
NightLight.Core.Tests/FakeHome.fs
View file

@ -44,8 +44,6 @@ type FakeLight(light: Light) =
color <- newColor color <- newColor
type FakeHome(now: DateTime) = type FakeHome(now: DateTime) =
let mutable time = now
let mutable nightLightStateMachine = NightLightStateMachine now let mutable nightLightStateMachine = NightLightStateMachine now
let assertIsOkAndGet result = let assertIsOkAndGet result =
@ -95,8 +93,6 @@ type FakeHome(now: DateTime) =
commands |> Seq.iter processCommand commands |> Seq.iter processCommand
nightLightStateMachine <- newState nightLightStateMachine <- newState
member _.Time = time
member _.LightStates = friendlyNameToFakeLight.Values |> Seq.map _.LightWithState member _.LightStates = friendlyNameToFakeLight.Values |> Seq.map _.LightWithState
member _.Interact(interaction: Interaction) = member _.Interact(interaction: Interaction) =
@ -113,9 +109,7 @@ type FakeHome(now: DateTime) =
|> ReceivedZigbeeEvent |> ReceivedZigbeeEvent
|> sendEvent |> sendEvent
| HumanInteraction(LightTurnedOff light) -> friendlyNameToFakeLight[light.FriendlyName].TurnOff() | HumanInteraction(LightTurnedOff light) -> friendlyNameToFakeLight[light.FriendlyName].TurnOff()
| TimeChanged newTime -> | TimeChanged newTime -> newTime |> Event.TimeChanged |> sendEvent
time <- newTime
newTime |> Event.TimeChanged |> sendEvent
type FakeHome with type FakeHome with
member this.Interact(interactions: Interaction seq) = interactions |> Seq.iter this.Interact member this.Interact(interactions: Interaction seq) = interactions |> Seq.iter this.Interact
@ -127,9 +121,3 @@ type FakeHome with
| On(brightness, color) -> Some(light, brightness, color) | On(brightness, color) -> Some(light, brightness, color)
| Off -> None) | Off -> None)
|> Seq.forall condition |> Seq.forall condition
member this.IsDay() =
this.Time.TimeOfDay >= TimeSpan.FromHours 5.5
&& this.Time.TimeOfDay < TimeSpan.FromHours 20.5
member this.IsNight() = not (this.IsDay())

24
NightLight.Core.Tests/NightLightTests.fs
View file

@ -4,6 +4,26 @@ open System
open FsCheck.Xunit open FsCheck.Xunit
open FsCheck.FSharp open FsCheck.FSharp
module InteractionsHelpers =
let getTimeAfter interactions =
interactions
|> Seq.choose (fun interaction ->
match interaction with
| TimeChanged time -> Some time
| _ -> None)
|> Seq.tryLast
|> function
| Some time -> time
| None -> failwith "Time wasn't changed"
let isDayAfter interactions =
let time = getTimeAfter interactions
time.TimeOfDay >= TimeSpan.FromHours 5.5
&& time.TimeOfDay < TimeSpan.FromHours 20.5
let isNightAfter = not << isDayAfter
[<Properties(Arbitrary = [| typeof<Arbitraries> |])>] [<Properties(Arbitrary = [| typeof<Arbitraries> |])>]
type NightLightTests() = type NightLightTests() =
[<Property>] [<Property>]
@ -17,7 +37,7 @@ type NightLightTests() =
let fakeHome = FakeHome now let fakeHome = FakeHome now
fakeHome.Interact interactions fakeHome.Interact interactions
fakeHome.IsNight() InteractionsHelpers.isNightAfter interactions
==> fakeHome.ForAllLightsThatAreOn(fun (_, _, color) -> color = Red) ==> fakeHome.ForAllLightsThatAreOn(fun (_, _, color) -> color = Red)
[<Property>] [<Property>]
@ -25,5 +45,5 @@ type NightLightTests() =
let fakeHome = FakeHome now let fakeHome = FakeHome now
fakeHome.Interact interactions fakeHome.Interact interactions
fakeHome.IsDay() InteractionsHelpers.isDayAfter interactions
==> fakeHome.ForAllLightsThatAreOn(fun (_, _, color) -> color = White || color = Yellow) ==> fakeHome.ForAllLightsThatAreOn(fun (_, _, color) -> color = White || color = Yellow)