svenvanheugten/night-light
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stop requiring the initial time in NightLightStateMachine

Browse source 
We're only fooling ourselves if we think that it's ready *right* after
construction anyway. After all, the initial state of the lights won't be
updated when the state machine is constructed.
This commit is contained in:
Sven van Heugten 2026-01-04 19:52:09 +01:00
parent db4434cd20
commit 9531dee52b
5 changed files with 31 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
NightLight.Core.Tests/FakeHome.fs
View file

@ -43,8 +43,8 @@ type FakeLight(light: Light) =
if hasPower then
color <- newColor
type FakeHome(now: DateTime) =
let mutable nightLightStateMachine = NightLightStateMachine now
type FakeHome() =
let mutable nightLightStateMachine = NightLightStateMachine()
let assertIsOkAndGet result =
match result with

12
NightLight.Core.Tests/NightLightTests.fs
View file

@ -27,22 +27,22 @@ module InteractionsHelpers =
[<Properties(Arbitrary = [| typeof<Arbitraries> |])>]
type NightLightTests() =
[<Property>]
let ``Brightness should always be under 255`` (now: DateTime) (interactions: Interaction list) =
let fakeHome = FakeHome now
let ``Brightness should always be under 255`` (interactions: Interaction list) =
let fakeHome = FakeHome()
fakeHome.Interact interactions
fakeHome.ForAllLightsThatAreOn(fun (_, brightness, _) -> brightness < 255uy)
[<Property>]
let ``Lights should be red during the night`` (now: DateTime) (interactions: Interaction list) =
let fakeHome = FakeHome now
let ``Lights should be red during the night`` (interactions: Interaction list) =
let fakeHome = FakeHome()
fakeHome.Interact interactions
InteractionsHelpers.isNightAfter interactions
==> fakeHome.ForAllLightsThatAreOn(fun (_, _, color) -> color = Red)
[<Property>]
let ``Lights should be white or yellow during the day`` (now: DateTime) (interactions: Interaction list) =
let fakeHome = FakeHome now
let ``Lights should be white or yellow during the day`` (interactions: Interaction list) =
let fakeHome = FakeHome()
fakeHome.Interact interactions
InteractionsHelpers.isDayAfter interactions